update yamls to adapt to oops/pull/2434 #986
Conversation
travissluka
added
the
waiting for another PR
travissluka
requested review from
guillaumevernieres,
kbhargava and
leungtszyan
ShastriPaturi
left a comment
ShastriPaturi
left a comment
There was a problem hiding this comment.
Approving it out of turn.
leungtszyan
left a comment
leungtszyan
left a comment
There was a problem hiding this comment.
I can see there is at least one other file (test/testinput/3dvar_single_ob.yaml) that hasn't implemented the change. Please check through all the test YAML files again.
|
Thanks for pushing the change. One more thing: the |
the ctests pass, the yaml files for all of the active test have already been updated. Anything left is not a test being exercised. Thank you for taking a look though. |
leungtszyan
left a comment
leungtszyan
left a comment
There was a problem hiding this comment.
Thanks for pushing the change. One more thing: the variational.iterations[n].online diagnostics.increment section also needs to be changed in a similar way (example), and I think there are multiple files that have this section in the YAML configuration.
Sorry I meant to refer to this example instead of the one hyperlinked above. Anyway, thanks for letting me know that this is not an active test. I can indeed see this in the CMakeLists.txt file. However, I would recommend that you update that YAML file as well, so that when the time comes for the test to be activated, the build could proceed smoothly. That being said, I am approving this PR in its current form, as it's not expected to break the existing tests as you said.
|
oops PR was merged, this is ready to merge now. |
7 participants
Description
update yamls for pending oops PR
FYI @guillaumevernieres @ShastriPaturi , you'll probably have to make a similar change in your workflow
dependencies
build-group=https://github.com/JCSDA-internal/oops/pull/2434